Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update type-fest and move to normal deps #345

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Conversation

achou11
Copy link
Member

@achou11 achou11 commented Oct 23, 2023

Updates type-fest from 3.10.0 to 4.5.0 and moves it to a normal dependency. The latter is necessary for type definitions to work as expected when @mapeo/core is used as a dependency in other projects.

Copy link
Member

@gmaclennan gmaclennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me. Failing test is due to a sodium-native crash, which might be related to https://github.com/sodium-friends/sodium-native/issues/158 and seems pretty random. Let's keep an eye if this is just node 16, and if so then hopefully the upgrade to node 18 will help.

@achou11 achou11 merged commit bac7f0d into main Oct 25, 2023
6 of 7 checks passed
@achou11 achou11 deleted the ac/type-fest-dep branch October 25, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants