fix: fix 'write EPIPE' error & failing discovery test #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs on this error: > EPIPE (Broken pipe): A write on a pipe, socket, or FIFO for which > there is no process to read the data. Commonly encountered at the net > and http layers, indicative that the remote side of the stream being > written to has been closed. This is happening when we close the connection but there is not yet an error handler on the socket. It's ok to ignore - so far as the consumer is concerned we haven't connected yet.
* main: feat: NamespaceSyncState improvements (#339) chore: update better-sqlite3 to 8.7.0 (#337) chore: update @mapeo/crypto to latest (#336) fix: write own device info when creating and adding projects (#297) Feat: add DataStore.writeRaw method (#334) feat: Add NamespaceSyncState (#313) chore: run CI on PRs against any branch (#330) feat: add capabilities.getAll() (#326)
gmaclennan
changed the title
achou11
approved these changes
Oct 20, 2023
gmaclennan
added a commit
that referenced
this pull request
Oct 22, 2023
* main: fix: fix 'write EPIPE' error & failing discovery test (#328)
This was referenced Nov 16, 2023
This was referenced Jun 20, 2024
This was referenced Jul 25, 2024
This was referenced Aug 21, 2024
This was referenced Aug 29, 2024
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs on this error:
This is happening when we close the connection but there is not yet an
error handler on the socket. It's ok to ignore - so far as the consumer
is concerned we haven't connected yet.
Turns out the other errors seen with discovery were due to not leaving enough delay before checking deduplication of incoming connections. The sodium-native upgrade to v4.0.4 seemed to highlight this because something is slower. It was hard to diagnose because tests were not failing on my (fast) macbook pro.
Also added catching of errors in tests which can happen when connections are deduplicated.
This PR also includes the update to sodium-native@4.0.4, so #338 is no longer needed if this is merged.