Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove ipc wrapper implementation #306

Merged
merged 1 commit into from
Oct 4, 2023
Merged

chore: remove ipc wrapper implementation #306

merged 1 commit into from
Oct 4, 2023

Conversation

achou11
Copy link
Member

@achou11 achou11 commented Oct 3, 2023

@achou11 achou11 requested a review from gmaclennan October 3, 2023 20:36
@achou11 achou11 self-assigned this Oct 3, 2023
@achou11 achou11 mentioned this pull request Oct 3, 2023
Closed
2 tasks
@achou11 achou11 force-pushed the 278/ipc-module branch 3 times, most recently from c2eb2d0 to 8ece56a Compare October 4, 2023 18:53
@gmaclennan
Copy link
Member

I was thinking about this more and wondering if it makes sense to keep the server implementation here and only have the client in a separate module? Maybe let's test it how it is and see if it causes any issues when using in mapeo mobile

@achou11
Copy link
Member Author

achou11 commented Oct 4, 2023

I was thinking about this more and wondering if it makes sense to keep the server implementation here and only have the client in a separate module? Maybe let's test it how it is and see if it causes any issues when using in mapeo mobile

yeah that may make sense. will give it some time before deciding on it

@achou11 achou11 merged commit 1e4f03b into main Oct 4, 2023
5 of 6 checks passed
@achou11 achou11 deleted the 278/ipc-module branch October 4, 2023 20:59
gmaclennan added a commit that referenced this pull request Oct 5, 2023
@gmaclennan
Merge branch 'main' into feat/namespace-sync-state
c01d160 
* main:
  chore: remove ipc wrapper implementation (#306)
  fix: fix DataType.getByDocId implementation to match type definition (#317)
  chore: Add CI release workflow (#300)
  Feat: Icon data type (#304)
  chore: emit peer-have messages, don't persist them (#310)
This was referenced Nov 16, 2023
Closed
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Dec 4, 2023
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Dec 12, 2023
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Mar 14, 2024
Merged
This was referenced Apr 11, 2024
Merged
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Apr 30, 2024
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request May 9, 2024
Merged
This was referenced Jun 20, 2024
Merged
Merged
Merged
This was referenced Jul 25, 2024
Merged
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Aug 13, 2024
Merged
This was referenced Aug 21, 2024
Merged
Merged
This was referenced Aug 29, 2024
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Sep 11, 2024
Closed
Merged
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmaclennan gmaclennan gmaclennan approved these changes

Assignees

@achou11 achou11

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Publish IPC wrapper as separate module
2 participants
@achou11 @gmaclennan