Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blobStore.createReadStream should not wait #243

Merged
merged 4 commits into from
Sep 6, 2023

Conversation

sethvincent
Copy link
Contributor

This adds wait and timeout options to blobStore.createReadStream.

It adds those options to blobStore.createEntryReadStream as well.

closes #80

Copy link
Member

@achou11 achou11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of non-blocking questions but overall looks good!

src/blob-store/index.js Outdated Show resolved Hide resolved
tests/blob-server.js Outdated Show resolved Hide resolved
tests/blob-server.js Show resolved Hide resolved
@achou11
Copy link
Member

achou11 commented Sep 5, 2023

also noticing that some of the files haven't been formatted using npm run format. we should probably set up a pre-commit step for this but in the meantime, mind running that on the relevant files?

@sethvincent sethvincent merged commit f0d9e95 into main Sep 6, 2023
@sethvincent sethvincent deleted the blobstore-createreadstream-options-#80 branch September 6, 2023 15:00
gmaclennan added a commit that referenced this pull request Sep 7, 2023
* main:
  expose member namespace in MapeoProject (#253)
  blobStore.createReadStream should not wait (#243)
  update MapeoManager to return and handle project public IDs (#247)
  return content hash from blobApi.create (#242)
gmaclennan added a commit that referenced this pull request Sep 12, 2023
* main:
  feat: Add set & get deviceInfo & datatype (#250)
  expose member namespace in MapeoProject (#253)
  blobStore.createReadStream should not wait (#243)
  update MapeoManager to return and handle project public IDs (#247)
  return content hash from blobApi.create (#242)
gmaclennan added a commit that referenced this pull request Sep 19, 2023
* main:
  chore: condense setup code in MemberAPI tests (#267)
  chore: replace queries opt in MemberAPI with dataType (#266)
  feat: add getMany method to member api (#263)
  feat: add getById method to member api (#262)
  chore: Update @digidem/types and remove patch (#269)
  feat: share all core keys via extension messages (#264)
  feat: send core "haves" bitfield on first connect (#254)
  fix: invite.encryptionKeys should be required (#260)
  feat: Add set & get deviceInfo & datatype (#250)
  expose member namespace in MapeoProject (#253)
  blobStore.createReadStream should not wait (#243)
  update MapeoManager to return and handle project public IDs (#247)
  return content hash from blobApi.create (#242)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

blobStore.createReadStream() should not "wait"
3 participants