Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add config store and preset & field types #174

Merged
merged 12 commits into from
Aug 15, 2023
Merged

Conversation

gmaclennan
Copy link
Member

@gmaclennan gmaclennan commented Aug 15, 2023

Currently depends on https://github.com/digidem/mapeo-schema/pull/117 and a new version of @mapeo/schema being published.

This adds two new data types: preset and field. They are stored in a new namespace called "config". The reason for keeping these data types in a separate namespace is to allow sync of only the config prior to syncing the rest of the data. We're not using the auth namespace because Mapeo Cloud needs the encryption key for that namespace, and we want to minimise the data that a server can see as unencrypted.

@gmaclennan gmaclennan self-assigned this Aug 15, 2023
@gmaclennan gmaclennan requested a review from achou11 August 15, 2023 14:04
@gmaclennan gmaclennan marked this pull request as draft August 15, 2023 14:05
Copy link
Member

@achou11 achou11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting change only because of the package.json change, otherwise lgtm!

package.json Outdated Show resolved Hide resolved
test-e2e/project-crud.js Outdated Show resolved Hide resolved
test-e2e/project-crud.js Outdated Show resolved Hide resolved
gmaclennan and others added 5 commits August 15, 2023 15:50
Co-authored-by: Andrew Chou <andrewchou@fastmail.com>
Co-authored-by: Andrew Chou <andrewchou@fastmail.com>
@gmaclennan gmaclennan marked this pull request as ready for review August 15, 2023 16:49
@gmaclennan gmaclennan requested a review from achou11 August 15, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConfigStore
2 participants