Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly generate column names in projectKeys table #173

Merged
merged 3 commits into from
Aug 14, 2023

Conversation

achou11
Copy link
Member

@achou11 achou11 commented Aug 14, 2023

Fixes a bug introduced in #169, as I used a for...in instead of a for...of loop...

Also creates the drizzle files becaues I forgot to do that in the other PR. My understanding is that it should be okay to overwrite the original migration files, as opposed to creating a new migration

Referencing #165 for linking purposes

@achou11 achou11 requested a review from gmaclennan August 14, 2023 20:18
Comment on lines 8 to 12
`0EncryptionKey` blob,
`1EncryptionKey` blob,
`2EncryptionKey` blob,
`3EncryptionKey` blob,
`randomEncryptionKey` blob
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major bug exposed 🙃 fixing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed via 8c53afe

@achou11 achou11 changed the title chore: regenerate client db files with drizzle fix: properly generate encryption key column names in projectKey table Aug 14, 2023
@achou11 achou11 changed the title fix: properly generate encryption key column names in projectKey table fix: properly generate column names in projectKey table Aug 14, 2023
@achou11 achou11 changed the title fix: properly generate column names in projectKey table fix: properly generate column names in projectKeys table Aug 14, 2023
Copy link
Member

@gmaclennan gmaclennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops I should have caught this in review

@achou11 achou11 merged commit 1f62404 into main Aug 14, 2023
@achou11 achou11 deleted the ac/regenerate-client-db branch August 14, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants