feat: MapeoProject class with updated DataStore, DataType & IndexWriter #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squashed commits: [a8267eb] Switch moduleResolution so @digidem/types work [1205a2b] Fixes and add forks [981070a] Add tests and fix accordingly [2dac678] Add tests and fixes [01ac065] add types for brittle [537ff7a] Add project, preset, field schemas [ad186ae] cleanup code and add comments [c23cf09] fix: extract correct schema w/out schemaName param [d8786c8] fix: docId as primary key [36eda92] fix enum type [f0c7eed] Remove db artifact [89468e2] WIP: Generate SQL table schema from JSON Schemas
TODO: Figure out best way to test types
Co-authored-by: Andrew Chou <andrewchou@fastmail.com>
Depends on: - [ ] digidem/mapeo-sqlite-indexer#11 - [ ] digidem/mapeo-sqlite-indexer#14 Makes more sense to e2e test rather than unit test, which depends on the new DataType class, which is next up.
Ensures you can't create a dataType in the wrong DataStore
- More explicit relationship between indexWriter and Datastore - Allows some type-checking to ensure IndexWriter can process entries
- better-sqlite3 instances = sqlite - drizzle table definitions = table
4 tasks
achou11
approved these changes
Aug 8, 2023
|
Changed base branch to |
gmaclennan
changed the title
MapeoProject classMapeoProject class with updated DataStore, DataType & IndexWriter
gmaclennan
changed the title
MapeoProject class with updated DataStore, DataType & IndexWriter
This was referenced Aug 9, 2023
Closed
This was referenced Nov 16, 2023
This was referenced Apr 11, 2024
This was referenced Jun 20, 2024
This was referenced Jul 25, 2024
This was referenced Aug 21, 2024
This was referenced Aug 29, 2024
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a new
MapeoProjectclass that integrates the newDataStore,IndexWriterandDataTypeclasses, and creates a minimal prototype for CRUD methods on observation records.