-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: serve blobs over http #117
Conversation
This initial implementation is done, but I have some questions:
I have a feeling that over time we will end up adding these ourselves when we would get them from Fastify. |
Discussed with @achou11 in-person.
Yes. Store in hyperdrive metadata. Read metadata as
Yes, although avoiding another fastify instance might be preferable, the simplicity gains of writing a raw http server are quickly lost as we add error handling and tackle edge-cases. In the future we can convert everything to fastify plugins and set fastify as a peer dependency so that we do not end up with multiple fastify instances. |
This reverts commit 9383baf. Just to figure out the original issue and go from there...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation all looks good. Just needs some more tests I think:
- Extract logic to populate the server with fixtures, to make tests easier to read (and clarify what they are testing)
- Test for valid URL but non-existent blob name and/or variant, should return 404
- Test for trying to read blob that exists but has not been replicated, should also return 404
Fixes #115