Skip to content

Commit

Permalink
chore: remove paths filter for lockfile workflow
Browse files Browse the repository at this point in the history
The "Check Lockfile" workflow had a paths filter
in the trigger, to only run when package-lock.json
is modified. Unfortunately there is an edge-case,
where package-lock.json is modified, and the
lockfile changes check posts a comment, and then
the package-lock.json changes are reverted, but
the lockfile changes check does not run again,
because now the PR has not updates to
`package-lock.json`.

This workflow is very fast compared with the other
checks in the repo, so I think it's ok to run for
every PR sync event.
  • Loading branch information
gmaclennan committed Oct 23, 2024
1 parent bddf7be commit 6f8cdb0
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/lockfile.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
name: Check Lockfile
on:
pull_request:
paths:
- 'package-lock.json'

jobs:
lockfile_version:
Expand Down

0 comments on commit 6f8cdb0

Please sign in to comment.