Change to Signed Statements for Hashed Payloads #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation improvements
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
|
Test of these updates: https://github.com/synsation-corp/synsation-web/actions/runs/9980507837 |
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
CBonnell
reviewed
Jul 19, 2024
| # now create a sha256 hash of the payload | ||
| # | ||
| # NOTE: any hashing algorithm can be used. | ||
| payload_hash = sha256(payload.encode("utf-8")).digest() |
There was a problem hiding this comment.
Future enhancement idea: fetch the payload at the payload location and compare its hash with the specified payload file hash
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
CBonnell
approved these changes
Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.