Adds types LoadBalancer and ClusterIP to valid service types #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblane-digicatapult
requested review from
mattdean-digicatapult,
darrylmorton-digicatapult and
jonmattgray
as code owners
dblane-digicatapult
force-pushed
the
feature/service-types
branch
from
7a56a70 to
2331c7a
Compare
mattdean-digicatapult
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to use different service types
ClusterIPandLoadBalancerLogic to determine if to use a public addr
Fixes some bugs in the parity chart with regards to bash flow logic on Parachain section
Parachain functionality needs to be tested against
Polkadotcontainer in the coming week.