Bug/Use original_id of parent for new token original_id #38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple tokens are about the same thing e.g a PO, we want them all to have the same
original_id
. This PR changes the pallet to correctly assignoriginal_id
rather than theid
of a parent to a new token'soriginal_id
.e.g. assuming all these tokens are about the same thing, such as a
Quote
. This PR goes from this:Token 1:
id: 1
original_id: 1
Token 2:
id: 2
original_id: 1
Token 3:
id: 3
original_id: 2
// this is wrongto this
Token 1:
id: 1
original_id: 1
Token 2:
id: 2
original_id: 1
Token 3:
id: 3
original_id: 1
// this is correct