Feature/in 121

[n3op2]

What

• added a new struct and a single storage map method with the process id as primary key - Version.

truct {
  process_id: [u8; 32] // process_id
  version: i32 // this should be changed to ProcessVersion type 
}

• some unit tests for the create process method and disable_process
• a couple of helper functions
• some logic for prevention of spamming events

Test coverage

~/workspace/vitalam-node (feature/in-121) $ RUST_BACKTRACE=1 cargo watch -x 'test  -p pallet-process-validation -- --nocapture'
[Running 'cargo test  -p pallet-process-validation -- --nocapture']
   Compiling pallet-process-validation v1.0.0 (/Users/PMichelevicius/workspace/vitalam-node/pallets/process-validation)
    Finished test [unoptimized + debuginfo] target(s) in 4.33s
     Running unittests (target/debug/deps/pallet_process_validation-73f8bab8c750bef3)

running 12 tests
test tests::__construct_runtime_integrity_test::runtime_integrity_tests ... ok
test tests::disable_process::returns_error_if_origin_validation_fails_and_no_data_added ... ok
test tests::disable_process::returns_error_if_process_does_not_exist ... ok
test tests::create_process::updates_version_correctly_for_new_process_and_dispatches_event ... ok
test tests::create_process::updates_version_correctly_for_existing_proces_and_dispatches_event ... ok
test tests::create_process::handles_if_process_exists_for_the_new_version ... ok
test tests::create_process::for_existing_process_it_mutates_an_existing_version ... ok
test tests::disable_process::disables_process_and_dispatches_event ... ok
test tests::create_process::if_no_version_found_it_should_return_default_and_insert_new_one ... ok
test tests::disable_process::returns_error_if_process_is_already_disabled ... ok
test tests::create_process::returns_error_if_origin_validation_fails_and_no_data_added ... ok
test tests::create_process::sets_versions_correctly_for_multiple_processes ... ok

test result: ok. 12 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s

   Doc-tests pallet-process-validation

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

[Finished running. Exit status: 0]

TODO

• - disable_process - will pair with Dan
• - Errors and maybe some handling
• - expand on unit tests coverage - create_process
• - write unit tests for disable_process - Dan
• - sort some types and a general clean up
• - resolve conflicts

[mattdean-digicatapult]

Alright this probably looks like a wall of changes but most of it is arround the switch to T::ProcessVersion. This is actually really close on the implmentation side, so well done! Couple of additional points:

1. Please rebase or merge in main. There's currently some churn from the cargo fmt
2. Tests need writing still, but I think you know that. Just a reminder

[mattdean-digicatapult]

Tests are looking good. Many points from the first review still remain but we're headed in the right direction. Few comments to look at

[danielcooperxyz]

You've done really well to pick this up and make something meaningful. Well done!

I don't have much to comment regarding the logic and types/structs. I noticed there are a lot of comments, some seem anecdotal whereas some seem more formal, also the formal comments are not always consistently applied i.e. method and variable documentation.

Is there a standard for code comment documentation in rust/substrate?

[mattdean-digicatapult]

Really close couple of minor changes. Also need to consider the following:

• bump pallet version
• bump runtime version (including the chain runtime version to match in the runtime lib.rs)
• bump node version

[mattdean-digicatapult]

Sorry I didn't comment all of these but it's the same thing with unit instead of bool if you want to

[n3op2]

🤦 sorry been rushing a little i guess and did not see that this repeats

[mattdean-digicatapult]

This version needs refencing in https://github.com/digicatapult/vitalam-node/blob/5ae336055621e016b1a1925605a67f01ae7018c0/runtime/src/lib.rs#L96

[jonmattgray]

Sorry to be the README troll, but this pallet has reached a point where it should have a section in the README? Like the sections for other pallets detailing their storage + extrinsics

[n3op2]

@jonmattgray - was actually thinking about this earlier in the morning, will add a README file

[mattdean-digicatapult]

@n3op2 I think this is good to merge. Don't worry about the readme, when I jump back to finishing off #36 I'll update the readme there. Good stuff