Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new versioning strategy #211

Merged
merged 2 commits into from
Nov 27, 2024
Merged

new versioning strategy #211

merged 2 commits into from
Nov 27, 2024

Conversation

Ellenn-A
Copy link
Contributor

Pull Request

Checklist

  • Have you read Digital Catapult's Code of Conduct?
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

PR Type

Please delete options that are irrelevant.

  • Bug Fix
  • Chore
  • Feature
  • Documentation Update
  • Code style update (formatting, local variables)
  • Breaking Change (fix or feature that would cause existing functionality to change)

Linked tickets

SQNC-73

High level description

Introduced new versioning strategy agreed in SQNC-41.

Detailed description

The agreed new strategy uses a single version set in the Cargo.toml at root level. this is then used by all the other Cargo.tomls.
We are from now on also incrementing spec_version by one e.g 1131 -> 1132 as part of a version bump.
Made a line change in check-version.sh to obtain current version from the root Cargo.toml instead of one in node.

Describe alternatives you've considered

As per SQNC-41, we have considered per-crate versioning strategy and a hybrid versioning approach. We have decided to proceed with Unified versioning as the crates are tightly coupled.

Operational impact

Additional context

@Ellenn-A Ellenn-A requested a review from a team as a code owner November 27, 2024 15:37
Copy link

This PR updates the following pallets - they may also require updates to their extrinsic weights:
process-validation symmetric-key utxo-nft

For the author and any reviewers:

  • consider whether the changes could significantly affect the weight of any extrinsics
  • consider whether benchmarks need updating to correctly cover weight variations over inputs

For a guide on running benchmarks to update weights see calculating weights

Copy link
Contributor

@mattdean-digicatapult mattdean-digicatapult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ellenn-A Ellenn-A merged commit caac142 into main Nov 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants