Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/upgrade deep deps #210

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Conversation

mattdean-digicatapult
Copy link
Contributor

@mattdean-digicatapult mattdean-digicatapult commented Nov 27, 2024

Pull Request

Checklist

  • Have you read Digital Catapult's Code of Conduct?
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

PR Type

Please delete options that are irrelevant.

  • Bug Fix
  • Chore
  • Feature
  • Documentation Update
  • Code style update (formatting, local variables)
  • Breaking Change (fix or feature that would cause existing functionality to change)

Linked tickets

https://digicatapult.atlassian.net/browse/SQNC-40

High level description

Upgrade deep deps

Detailed description

Should have been included in #208. This upgrades deep deps and removes the try-runtime-cli which is unused

Describe alternatives you've considered

None

Operational impact

None

Additional context

N/A

Copy link

This PR updates the following pallets - they may also require updates to their extrinsic weights:
process-validation symmetric-key utxo-nft

For the author and any reviewers:

  • consider whether the changes could significantly affect the weight of any extrinsics
  • consider whether benchmarks need updating to correctly cover weight variations over inputs

For a guide on running benchmarks to update weights see calculating weights

@mattdean-digicatapult mattdean-digicatapult marked this pull request as ready for review November 27, 2024 11:03
@mattdean-digicatapult mattdean-digicatapult requested a review from a team as a code owner November 27, 2024 11:03
Cargo.toml Show resolved Hide resolved
@mattdean-digicatapult mattdean-digicatapult merged commit a87ccf5 into main Nov 27, 2024
8 checks passed
@mattdean-digicatapult mattdean-digicatapult deleted the chore/upgrade-deep-deps branch November 27, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants