Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable react-docgen-typescript in Storybook #2173

Closed
Barsnes opened this issue Jul 3, 2024 · 0 comments · Fixed by #2521
Closed

re-enable react-docgen-typescript in Storybook #2173

Barsnes opened this issue Jul 3, 2024 · 0 comments · Fixed by #2521
Labels
📔 storybook storybook.designsystemet.no

Comments

@Barsnes
Copy link
Member

Barsnes commented Jul 3, 2024

After testing and debugging, using react-docgen-typescript locally makes Storybook unbelievably slow.

I changed our setup to only use it in production, and locally use react-docgen, which has no performance issues.
This is the same bug as reported in storybookjs/storybook#28269.

When the issue above is resolved, we can change to use this:

reactDocgen: 'react-docgen-typescript',
reactDocgenTypescriptOptions: {
  compilerOptions: {
    allowSyntheticDefaultImports: false,
    esModuleInterop: false,
  },
  tsconfigPath: resolve(__dirname, '../../packages/react/tsconfig.json'),
}
@github-project-automation github-project-automation bot moved this to 🔵 Inbox in Team Design System Jul 3, 2024
@Barsnes Barsnes added the 📔 storybook storybook.designsystemet.no label Jul 3, 2024
@mrosvik mrosvik moved this from 🔵 Inbox to 📋 Backlog in Team Design System Aug 5, 2024
Barsnes added a commit that referenced this issue Aug 14, 2024
args tables are not currently working in production. 
This PR fixes this. `react-docgen` is still used in local development,
due to #2173, so you have to check this is production.

See preview deployment.

Also updates to a minor version of storybook.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Team Design System Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📔 storybook storybook.designsystemet.no
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant