Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: libro lsp client with notebook support #40

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

zhanba
Copy link
Contributor

@zhanba zhanba commented Jan 4, 2024

This pr implements notebook lsp(3.17) support for libro editor.

  • fork from vscode-languageserver-node
  • redirect vscode api to libro, in detail:
    • redirect window\workspace api to libro service
    • redirect languages api to monaco editor languages api

for now, we get:

  • notebook file sync in LSP protocol
  • lint and format with ruff-lsp
  • diagnostic, completion and hover with libro-analyzer

lint format

Copy link

changeset-bot bot commented Jan 4, 2024

⚠️ No Changeset found

Latest commit: 74cb210

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@zhanba zhanba force-pushed the feat-language-client branch 4 times, most recently from a9e9c83 to 2119504 Compare January 22, 2024 04:58
@zhanba zhanba marked this pull request as ready for review January 24, 2024 09:11
@zhanba zhanba requested a review from BroKun January 24, 2024 09:11
@zhanba zhanba force-pushed the feat-language-client branch 5 times, most recently from 3f77cd3 to 487caf8 Compare January 30, 2024 10:52
Copy link
Member

@BroKun BroKun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

把提交折叠一下,
感觉本地的 prettier 版本有问题 json 都在最后一项的尾部加了逗号,这个是不对的

@zhanba zhanba force-pushed the feat-language-client branch from fc1d428 to fe18860 Compare February 4, 2024 06:43
@zhanba
Copy link
Contributor Author

zhanba commented Feb 4, 2024

tailing comma see #prettier/prettier#15942

@zhanba zhanba force-pushed the feat-language-client branch from e318bd7 to d3973bc Compare February 4, 2024 07:09
@zhanba zhanba changed the title feat: libro language client feat: libro lsp language client with notebook support Feb 4, 2024
@zhanba zhanba changed the title feat: libro lsp language client with notebook support feat: libro lsp client with notebook support Feb 4, 2024
@zhanba zhanba force-pushed the feat-language-client branch from d3973bc to 74cb210 Compare February 5, 2024 03:18
Copy link
Member

@BroKun BroKun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BroKun BroKun merged commit f2fca0f into main Feb 5, 2024
1 check passed
@sunshinesmilelk sunshinesmilelk deleted the feat-language-client branch October 9, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants