-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move tests folder #99
Conversation
The CI fails because the installed package is unable to find example data. Please add a line From
to
|
So, to mimic the CI behavior, you can run If you use |
thanks for the comment! @bobleesj |
@yucongalicechen Just a quick heads up that we might do a quick re-cookiecutter for all diffpy projects we have all the issues addressed here: https://github.com/Billingegroup/cookiecutter/milestone/6 Since all the tests are running smoothly at the top directory level, it will be very easy! |
I'm adding back labpdfproc command here because I notice it disappears again on our main branch, but I remembered adding it back in one of the previous PRs... not sure what happened. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good. We should be able to delete init.py from the tests folder. Please can you delete that and see if everything still passes?
Then I think it is ready, it looks good.
Deleted! :) |
closes #98