Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tests folder #99

Merged
merged 6 commits into from
Sep 13, 2024
Merged

Move tests folder #99

merged 6 commits into from
Sep 13, 2024

Conversation

yucongalicechen
Copy link
Collaborator

closes #98

@bobleesj
Copy link
Contributor

bobleesj commented Sep 9, 2024

@yucongalicechen

The CI fails because the installed package is unable to find example data.

Please add a line MANIFEST.in to import the test data as well.

From

recursive-exclude * __pycache__

to

recursive-include src/diffpy/labpdfproc/data *
recursive-exclude * __pycache__

@bobleesj
Copy link
Contributor

bobleesj commented Sep 9, 2024

So, to mimic the CI behavior, you can run pytest -vv after pip install . instead of pip install -e ..

If you use pip install ., you can confirm that the you are running the tests from the installed package located in miniconda3, etc.

@yucongalicechen
Copy link
Collaborator Author

thanks for the comment! @bobleesj

@bobleesj
Copy link
Contributor

@yucongalicechen Just a quick heads up that we might do a quick re-cookiecutter for all diffpy projects we have all the issues addressed here: https://github.com/Billingegroup/cookiecutter/milestone/6

Since all the tests are running smoothly at the top directory level, it will be very easy!

@yucongalicechen
Copy link
Collaborator Author

I'm adding back labpdfproc command here because I notice it disappears again on our main branch, but I remembered adding it back in one of the previous PRs... not sure what happened.
@sbillinge I think this PR is ready for review, thanks!

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. We should be able to delete init.py from the tests folder. Please can you delete that and see if everything still passes?

Then I think it is ready, it looks good.

@yucongalicechen
Copy link
Collaborator Author

Deleted! :)

@sbillinge sbillinge merged commit adee9b2 into diffpy:main Sep 13, 2024
3 checks passed
@yucongalicechen yucongalicechen deleted the move-tests branch September 25, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move tests folder at the root of the repo
3 participants