Remove questionable default targets #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nedtwigg
force-pushed
the
feat/remove-questionable-defaults
branch
from
8459534
to
d05f9ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a bunch of languages which don't have a well-established folder structure in the gradle or maven ecosystems (specifically
C/C++,typescript,markdown/freshmark, andsql). Previously we had used heavy wildcards (e.g.**/*.md), which are wildly inefficient, and often cause subprojects to be formatted multiple times (possibly in conflicting ways).For these languages, it would be better for the user to provide a hand-crafted target. For example, our current
C/C++default of**/*.h, **/*.hpp, **/*.c, **/*.cpp **/*.inc, ...can often be replaced by justsrc/**, which performs far better and requires less documentation.This PR turns these defaults into an error message in maven, and a deprecation warning (soon to be error) in gradle. Although it is a breaking change to remove these defaults, it would not be a breaking change to add them back. So if you disagree with this change, please feel free to speak up here in this PR.