Feature/build cleanup #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
[WARNING]
[WARNING] Some problems were encountered while building the effective model for com.diffplug.spotless:spotless-maven-plugin:maven-plugin:1.25.0-SNAPSHOT
[WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: org.codehaus.plexus:plexus-resources:jar -> version ${plexus.resources.version} vs 1.0.1 @ line 71, column 17
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING]
```
|
Turns out we are double-specifying the plexus-resources jar, which is causing this warning: I will fix that in the next commit. |
…pecial plugin-maven build makes java-library irrelevant. Revealed the following undeclared deps: - plugin-gradle needed durian-collect in its implementation - plugin-maven needed durian-core and durian-collect in its implementation, and durian-io in its testImplementation
nedtwigg
force-pushed
the
feature/buildCleanup
branch
from
0b69e3b to
59d3ce4
Compare
|
Wow, great work on the build improvements @nedtwigg! However, I'm unclear as to why not all of the |
|
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master is passing again. I pushed d5f8251 straight to master and updated our encrypted environment variables to get it working.
I'd like to use this PR as a misc opportunity to cleanup the build. Having a fix for #429 would be great, but I don't have any ideas.