Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/fix http #361

Merged
merged 8 commits into from
Feb 26, 2019
Merged

Feature/fix http #361

merged 8 commits into from
Feb 26, 2019

Conversation

nedtwigg
Copy link
Member

  • a summary of the change
  • either
    • a link to the issue you are resolving (for small changes)
    • a link to the PR you just created (for big changes likely to have discussion)

@nedtwigg
Copy link
Member Author

Beginnings of addressing #360

JLLeitschuh
JLLeitschuh approved these changes Feb 25, 2019
View reviewed changes
Copy link
Member

@JLLeitschuh JLLeitschuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for doing the legwork here!

@nedtwigg nedtwigg merged commit 1a3e260 into master Feb 26, 2019
@nedtwigg nedtwigg deleted the feature/fixHttp branch February 26, 2019 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JLLeitschuh JLLeitschuh JLLeitschuh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nedtwigg @JLLeitschuh