Require 3.1.0+ version of Maven for Maven plugin #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Such runtime requirement exists because plugin uses APIs only available starting from 3.1.0 version of Maven. They are used for artifact resolution and come from the `org.eclipse.aether` package which does not exist in < 3.1.0 Maven versions. Requirement is declared in a `<prerequisites>` section of the POM. This section is deprecated for regular projects and should only be used by plugins to declare a minimum Maven version. Old versions will make the plugin execution fail with an error: ``` [ERROR] Failed to execute goal c.d.s:spotless-maven-plugin:X.Y.Z:apply (default-cli) on project test: The plugin c.d.s:spotless-maven-plugin:X.Y.Z requires Maven version 3.1.0 -> [Help 1] ``` Also added a note in the README about the minimum required Maven version.
lutovich
force-pushed
the
mvn-plugin-required-mvn-version
branch
from
1b39213
to
7818509
Compare
|
Thanks @lutovich! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Such runtime requirement exists because plugin uses APIs only available starting from 3.1.0 version of Maven. They are used for artifact resolution and come from the
org.eclipse.aetherpackage which does not exist in < 3.1.0 Maven versions.Requirement is declared in a
<prerequisites>section of the POM. This section is deprecated for regular projects and should only be used by plugins to declare a minimum Maven version. Old versions will make the plugin execution fail with an error:Also added a note in the README about the minimum required Maven version.
Resolves #257