Fix compatibility issue introduced by ktfmt 0.51 #2172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hick209
commented
Jun 14, 2024
•
hick209
commented
- Closes Gradle plugin 6.25.0 incompatible with ktfmt 0.51 #2171.
- Handles Update dependency com.facebook:ktfmt to v0.51 - autoclosed #2163.
Goooler
changed the title
Goooler
reviewed
Jun 16, 2024
plugin-maven/src/main/java/com/diffplug/spotless/maven/kotlin/Ktfmt.java
Show resolved
Hide resolved
Goooler
reviewed
Jun 17, 2024
lib/src/ktfmt/java/com/diffplug/spotless/glue/ktfmt/KtfmtFormatterFunc.java
Show resolved
Hide resolved
lib/src/ktfmt/java/com/diffplug/spotless/glue/ktfmt/KtfmtFormatterFunc.java
Show resolved
Hide resolved
|
Thanks @Goooler for helping making the code in this PR better 😃 |
|
Looking into the issue you see there @Goooler, it does not look related to my changes. |
Goooler
approved these changes
Jun 18, 2024
| def args = [ | ||
| '--add-opens=java.base/java.lang=ALL-UNNAMED' | ||
| '--add-opens=java.base/java.lang=ALL-UNNAMED', | ||
| '--add-opens=java.base/java.util=ALL-UNNAMED', |
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks for the fix!
I still wonder if this is related to my changes though, it does not look like it to me, but I'm fine with us landing it as part of this PR
There was a problem hiding this comment.
Nope, this is a behavior change from Gradle 7.5, it affects tests.
Thanks for your great work here!
|
Your tests passed may be due to you using Java 11. |
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.