Remove JvmLocalCache now that everything is round-trippable on its own
#2088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nedtwigg
commented
Apr 4, 2024
nedtwigg
commented
- Capstone piece of Support Gradle configuration cache on multiple JVMs #1274
Goooler
approved these changes
Apr 5, 2024
plugin-gradle/src/main/java/com/diffplug/gradle/spotless/SpotlessTask.java
Outdated
Show resolved
Hide resolved
jbduncan
reviewed
Apr 6, 2024
| @@ -151,10 +151,10 @@ void customRunToFixMessage() throws Exception { | |||
| @Test | |||
| void whitespaceProblem() throws Exception { | |||
| Bundle spotless = create(setFile("testFile").toContent("A \nB\t\nC \n")); | |||
| spotless.task.addStep(FormatterStep.createNeverUpToDate("trimTrailing", input -> { | |||
| spotless.task.setSteps(List.of(FormatterStep.createNeverUpToDate("trimTrailing", input -> { | |||
There was a problem hiding this comment.
I'm tempted to revert this code change and all other addStep -> setStep changes. WDYT?
There was a problem hiding this comment.
I can see an argument for setSteps(FormatterStep... steps) to remove the manual List.of, but I think the mutable-naming addStep is bad. It's used only for a few tests, which is why I just did the List.of.
There was a problem hiding this comment.
Fair enough! I have no strong opinions either way, so I'm happy to continue with setSteps.
…essTask.java Co-authored-by: Zongle Wang <wangzongler@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.