Bump minimum JRE to 11 (gracefully) #1514

nedtwigg · 2023-01-24T00:40:20Z

This PR does the following things

it stops running CI against Java 8
it removes some Java 8 specific workarounds
the gradle plugin yells at Java 8 users and points them to
- https://docs.gradle.org/current/userguide/building_java_projects.html#sec:java_cross_compilation
the maven plugin yells at Java 8 users and points them to
- https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-source-and-target.html

However, this plugin still compiles for Java 8, and it does not require any non-Java 8 transitive dependencies. Once we have merged and released this PR, we will then actually bump our bytecode to Java 11 and bump our transitives to java 11.

This PR is part 1 (of 2) for:

Bump minimum required JRE to 11? #1337

…nds on my M1) and it's confusing to PR authors to not run.

…Java 11 anymore anyway.

…, and how to update without affecting their users.

…tion. A job for the unit tests, not the integration tests.

nedtwigg · 2023-01-26T20:37:25Z

Released in plugin-gradle 6.14.0 and plugin-maven 2.31.0.

### What changes were proposed in this pull request? This PR pins `spotless` to 2.30.0. ### Why are the changes needed? `spotless` dropped Java 8 support at 2.31.0. - diffplug/spotless#1514 - #1392 ### How was this patch tested? Manual review.

### What changes were proposed in this pull request? This PR pins `spotless` to 2.30.0. ### Why are the changes needed? `spotless` dropped Java 8 support at 2.31.0. - diffplug/spotless#1514 - #1392 ### How was this patch tested? Manual review. (cherry picked from commit 14fba6a) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>

This MR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [com.diffplug.spotless:spotless-maven-plugin](https://github.com/diffplug/spotless) | build | minor | `2.32.0` -> `2.33.0` | | [io.quarkus:quarkus-maven-plugin](https://github.com/quarkusio/quarkus) | build | patch | `2.16.1.Final` -> `2.16.2.Final` | | [io.quarkus:quarkus-universe-bom](https://github.com/quarkusio/quarkus-platform) | import | patch | `2.16.1.Final` -> `2.16.2.Final` | --- ### Release Notes <details> <summary>diffplug/spotless</summary> ### [`v2.33.0`](https://github.com/diffplug/spotless/blob/HEAD/CHANGES.md#2330---2023-01-26) ##### Added - `ProcessRunner` has added some convenience methods so it can be used for maven testing. ([#1496](diffplug/spotless#1496)) - `ProcessRunner` allows to limit captured output to a certain number of bytes. ([#1511](diffplug/spotless#1511)) - `ProcessRunner` is now capable of handling long-running tasks where waiting for exit is delegated to the caller. ([#1511](diffplug/spotless#1511)) - Allow to specify node executable for node-based formatters using `nodeExecutable` parameter ([#1500](diffplug/spotless#1500)) ##### Fixed - The default list of type annotations used by `formatAnnotations` has had 8 more annotations from the Checker Framework added [#1494](diffplug/spotless#1494) ##### Changes - **POTENTIALLY BREAKING** Bump minimum JRE from 8 to 11, next release likely to bump bytecode to Java 11 ([#1514](diffplug/spotless#1514) part 1 of [#1337](diffplug/spotless#1337)) - Rename `YamlJacksonStep` into `JacksonYamlStep` while normalizing Jackson usage ([#1492](diffplug/spotless#1492)) - Convert `gson` integration to use a compile-only source set ([#1510](diffplug/spotless#1510)). - \*\* POTENTIALLY BREAKING\*\* Removed support for KtLint 0.3x and 0.45.2 ([#1475](diffplug/spotless#1475)) - `KtLint` does not maintain a stable API - before this MR, we supported every breaking change in the API since 2019. - From now on, we will support no more than 2 breaking changes at a time. - NpmFormatterStepStateBase delays `npm install` call until the formatter is first used. This enables better integration with `gradle-node-plugin`. ([#1522](diffplug/spotless#1522)) - Bump default `ktlint` version to latest `0.48.1` -> `0.48.2` ([#1529](diffplug/spotless#1529)) - Bump default `scalafmt` version to latest `3.6.1` -> `3.7.1` ([#1529](diffplug/spotless#1529)) </details> <details> <summary>quarkusio/quarkus</summary> ### [`v2.16.2.Final`](https://github.com/quarkusio/quarkus/releases/tag/2.16.2.Final) [Compare Source](quarkusio/quarkus@2.16.1.Final...2.16.2.Final) ##### Complete changelog - [#30976](quarkusio/quarkus#30976) - Metrics - check if index contains class before attempting to use it - [#30965](quarkusio/quarkus#30965) - JandexBeanInfoAdapter.getMetricAnnotationsThroughStereotype is not null safe - [#30959](quarkusio/quarkus#30959) - Return text from /q/metrics when the Accept header contains html - [#30953](quarkusio/quarkus#30953) - Fix OIDC capability string - [#30947](quarkusio/quarkus#30947) - Ignore interface/class without default constructs fields in SB config - [#30940](quarkusio/quarkus#30940) - Use SchemaType.ARRAY instead of "ARRAY" for native support - [#30919](quarkusio/quarkus#30919) - Compilation to native fails, when quarkus-smallrye-openapi is included - [#30916](quarkusio/quarkus#30916) - Add AppCDS documentation - [#30896](quarkusio/quarkus#30896) - Quarkus spring-boot-properties extension unable to handle complex configuration. - [#30878](quarkusio/quarkus#30878) - Bump postgresql from 42.5.2 to 42.5.3 - [#30866](quarkusio/quarkus#30866) - Only run the quickstart compilation for main - [#30851](quarkusio/quarkus#30851) - Fixed return type typo in smallrye graphQL guide - [#30844](quarkusio/quarkus#30844) - Fixed greeting in getting started guide - [#30839](quarkusio/quarkus#30839) - Fix handling of Accept header in graphQL - [#30833](quarkusio/quarkus#30833) - Update docs to show BuildProducer use as method parameter instead of field - [#30828](quarkusio/quarkus#30828) - Make OIDC session cookie same site lax by default - [#30826](quarkusio/quarkus#30826) - Caffeine - Automatically register metrics cache impls if Micrometer is around - [#30825](quarkusio/quarkus#30825) - Fix comment about Caffeine optimization - [#30823](quarkusio/quarkus#30823) - Change accept header to valid plain text in micrometer documentation - [#30821](quarkusio/quarkus#30821) - Packaging type -Dquarkus.package.create-appcds=true isn't documented - [#30815](quarkusio/quarkus#30815) - Update SmallRye Config to 2.13.2 - [#30812](quarkusio/quarkus#30812) - Manage the apache-mime4j dependency - [#30806](quarkusio/quarkus#30806) - */* in Accept header is ignored if not listed as the first item - [#30805](quarkusio/quarkus#30805) - MailTemplateInstance with attachments - [#30803](quarkusio/quarkus#30803) - Support file and byte array attachments in `MailTemplateInstance` - [#30797](quarkusio/quarkus#30797) - OIDC login not work - [#30783](quarkusio/quarkus#30783) - <artifactId> uses 'quarkus.platform.artifact-id' property - [#30778](quarkusio/quarkus#30778) - Avoid creating 3 Liquibase MongoDB instances for startup operations - [#30776](quarkusio/quarkus#30776) - Ensure that AwsProxyRequestContext can be used with [@Context](https://github.com/Context) in RESTEasy Reactive - [#30767](quarkusio/quarkus#30767) - Remove duplicate notification of SseBroadcaster's onErrorListeners - [#30765](quarkusio/quarkus#30765) - Bump postgresql from 42.5.1 to 42.5.2 - [#30755](quarkusio/quarkus#30755) - Update ForwardedParser to validate the port - [#30744](quarkusio/quarkus#30744) - \[Quarkus Native] ClassNotFoundException: com.github.benmanes.caffeine.cache.SSSW - [#30536](quarkusio/quarkus#30536) - munitnyucontextmanager non helpful error reporting - [#29753](quarkusio/quarkus#29753) - Introduce ConnectionFactoryWrapperBuildItem - [#29605](quarkusio/quarkus#29605) - Update docs to reflect that injection should not - [#27774](quarkusio/quarkus#27774) - PLANNER-1709 Avoid deprecated penalize/reward overloads - [#23442](quarkusio/quarkus#23442) - problem using quarkus-resteasy-reactive-kotlin-serialization with AwsProxyRequestContext </details> <details> <summary>quarkusio/quarkus-platform</summary> ### [`v2.16.2.Final`](quarkusio/quarkus-platform@2.16.1.Final...2.16.2.Final) [Compare Source](quarkusio/quarkus-platform@2.16.1.Final...2.16.2.Final) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This MR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

### What changes were proposed in this pull request? This PR pins `spotless` to 2.30.0. ### Why are the changes needed? `spotless` dropped Java 8 support at 2.31.0. - diffplug/spotless#1514 - apache#1392 ### How was this patch tested? Manual review.

nedtwigg added 5 commits January 23, 2023 16:58

Stop running CI on java 8.

0b2a329

Run spotbugs on all supported JRE because it's not that slow (17 seco…

826760d

…nds on my M1) and it's confusing to PR authors to not run.

Remove @EnabledForJreRange(min = JAVA_11) since we don't support < …

1c5a3ef

…Java 11 anymore anyway.

The maven and gradle plugins yell at their users to update to Java 11…

14e71fb

…, and how to update without affecting their users.

Update changelogs.

b0975be

nedtwigg force-pushed the feat/bump-to-11 branch from d46b4fe to b0975be Compare January 24, 2023 01:03

nedtwigg mentioned this pull request Jan 24, 2023

Bump minimum required JRE to 11? #1337

Closed

nedtwigg requested a review from jbduncan January 24, 2023 01:24

nedtwigg mentioned this pull request Jan 26, 2023

add ability to use npm and node executables installed by node gradle plugin #1522

Merged

nedtwigg added 3 commits January 25, 2023 22:41

Merge branch 'main' into feat/bump-to-11

752b53a

Improved KtLintStepTest.equality to not download so much.

56a6f7e

The Kotlin gradle integration tests had tested every possible combina…

fb03922

…tion. A job for the unit tests, not the integration tests.

nedtwigg merged commit 6b3ab24 into main Jan 26, 2023

nedtwigg deleted the feat/bump-to-11 branch January 26, 2023 18:29

dongjoon-hyun mentioned this pull request Feb 1, 2023

ORC-1364: Pin spotless to 2.30.0 apache/orc#1395

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump minimum JRE to 11 (gracefully) #1514

Bump minimum JRE to 11 (gracefully) #1514

nedtwigg commented Jan 24, 2023 •

edited

Loading

nedtwigg commented Jan 26, 2023

Bump minimum JRE to 11 (gracefully) #1514

Bump minimum JRE to 11 (gracefully) #1514

Conversation

nedtwigg commented Jan 24, 2023 • edited Loading

nedtwigg commented Jan 26, 2023

nedtwigg commented Jan 24, 2023 •

edited

Loading