Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension requiring external libraries on demand use the buildscript of the root project for lookup #123

Merged
merged 2 commits into from
Jul 11, 2017
Merged

Extension requiring external libraries on demand use the buildscript of the root project for lookup #123

merged 2 commits into from
Jul 11, 2017

Conversation

fvgh
Copy link
Member

@fvgh fvgh commented Jul 5, 2017

With #99 the current project was used, which makes the resulting configuration unnecessarily complex for multi-project builds.

@fvgh
Extension requiring external libraries on demand use the buildscript …
c188743 
…of the root project for lookup.

With #99 the current project was used, which makes the resulting configuration unnecessarily complex for multi-project builds.
@fvgh fvgh requested a review from nedtwigg July 5, 2017 06:39
@fvgh
Copy link
Member Author

fvgh commented Jul 5, 2017

Implementation is based on agreement fond for #120.
Please have a look on the documentation extensions / error message.
I am not a native speaker, so maybe there is some polishing required.
THX

@fvgh
Copy link
Member Author

fvgh commented Jul 5, 2017

@nedtwigg
The release has no hurry. I am waiting for getting the formatting of gradle files agreed with the JUnit team.
I tested this change with JUnit, but will not propose the resulting simplification of the JUnit build before the previous task is done.

@nedtwigg
Most users won't need to alter the buildscript repositories, and thos…
430463f 
…e that do will be notified by the very nice error message @fvgh created in the previous commit, so I'm inclined to keep the README more brief.
@nedtwigg
Copy link
Member

Sorry for the delay on this @fvgh. I'm gonna do some quick integration testing, then turn the release crank.

@nedtwigg nedtwigg merged commit ea44821 into master Jul 11, 2017
@nedtwigg
Copy link
Member

Released in 3.4.1

@fvgh fvgh deleted the extensions-repoitories-from-root-project branch August 7, 2017 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nedtwigg nedtwigg Awaiting requested review from nedtwigg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fvgh @nedtwigg