Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No need for clean to trigger configuration of the spotless tasks if 'base' was already applied #1068

Merged
merged 8 commits into from
Jan 6, 2022
Merged

No need for clean to trigger configuration of the spotless tasks if 'base' was already applied #1068

merged 8 commits into from
Jan 6, 2022

Conversation

nedtwigg
Copy link
Member

@nedtwigg nedtwigg commented Jan 6, 2022

As noted by @nhoughto here.

@nedtwigg
Revert "Fix SpotlessPlugin.taskMustRunAfterClean"
6442fdf 
This reverts commit 5ee9046.

As noted by @nhoughto, this change causes eager configuration of Spotless tasks when `clean` is configured, but it is not necessary.

 5ee9046#commitcomment-62989038
@nedtwigg
Update changelog.
7c10a74
@nedtwigg
Spotless.
e648217
@nedtwigg nedtwigg disabled auto-merge January 6, 2022 03:44
@nedtwigg
Copy link
Member Author

nedtwigg commented Jan 6, 2022

Oops, looks like there is a reason. Copied from the copious CI failures:

> Could not create task ':clean'.
   > DefaultTaskContainer#NamedDomainObjectProvider.configure(Action) on task set cannot be executed in the current context.

@nedtwigg nedtwigg closed this Jan 6, 2022
@nedtwigg nedtwigg changed the title No need for clean to trigger configuration of the spotless tasks No need for clean to trigger configuration of the spotless tasks (Oops, there is) Jan 6, 2022
@nedtwigg nedtwigg reopened this Jan 6, 2022
@nedtwigg nedtwigg changed the title No need for clean to trigger configuration of the spotless tasks (Oops, there is) No need for clean to trigger configuration of the spotless tasks if 'base' was already applied Jan 6, 2022
nedtwigg referenced this pull request Jan 6, 2022
@nedtwigg
Fix SpotlessPlugin.taskMustRunAfterClean
5ee9046
@nedtwigg nedtwigg merged commit b3a6e36 into main Jan 6, 2022
@nedtwigg nedtwigg deleted the fix/clean-triggers-configure branch January 6, 2022 04:59
@nedtwigg
Copy link
Member Author

nedtwigg commented Jan 6, 2022

Released in 6.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nedtwigg