ratchetFrom not working in git-submodule

[conderls]

If you are submitting a bug, please include the following:

• summary of problem
  ratchetFrom not working if current project is a git-submodule. if <ratchetFrom>origin/master</ratchetFrom> section is set, nothing happended. But if the <ratchetFrom> is removed, everything works fine.
• gradle or maven version
  maven 3.6.5
• spotless version
  2.6.1
• operating system and version
  Mac

there is no .git dir in git-submodule which is presented in parent module directory. Is It parsing and filter modified files using ./.git directory?

[conderls]

BTW, why not using 'origin/master' instead of 'origin/main' in <ratchetFrom> by default.

[nedtwigg]

Interesting... I thought that we did support submodule, but we don't have a test for that, so not too surprised if it is broken. This is probably where the bug lives, PR's welcome.

spotless/lib-extra/src/main/java/com/diffplug/spotless/extra/GitRatchet.java

Lines 201 to 228 in d9474fb

	public synchronized ObjectId rootTreeShaOf(Project project, String reference) {
	try {
	Repository repo = repositoryFor(project);
	ObjectId treeSha = rootTreeShaCache.get(repo, reference);
	if (treeSha == null) {
	try (RevWalk revWalk = new RevWalk(repo)) {
	ObjectId commitSha = repo.resolve(reference);
	if (commitSha == null) {
	throw new IllegalArgumentException("No such reference '" + reference + "'");
	}
	RevCommit ratchetFrom = revWalk.parseCommit(commitSha);
	RevCommit head = revWalk.parseCommit(repo.resolve(Constants.HEAD));
	revWalk.setRevFilter(RevFilter.MERGE_BASE);
	revWalk.markStart(ratchetFrom);
	revWalk.markStart(head);
	RevCommit mergeBase = revWalk.next();
	treeSha = Optional.ofNullable(mergeBase).orElse(ratchetFrom).getTree();
	}
	rootTreeShaCache.put(repo, reference, treeSha);
	}
	return treeSha;
	} catch (IOException e) {
	throw Errors.asRuntime(e);
	}
	}

why not using 'origin/master' instead of 'origin/main'

https://www.infoq.com/news/2020/10/github-main-branch/

[nedtwigg]

Fixed in plugin-gradle 5.9.0 and plugin-maven 2.7.0, can you confirm?

[nedtwigg]

Bump.