-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ktlint 0.38.0-alpha01 incompatibility #668
Comments
Actually, I think that this may be a parsing error due to the Parsing is here https://github.com/diffplug/spotless/blob/main/lib/src/main/java/com/diffplug/spotless/kotlin/KtLintStep.java#L105 |
Yeah I think that's the issue, it expects semver without qualifiers https://github.com/diffplug/spotless/blob/main/lib/src/main/java/com/diffplug/spotless/kotlin/KtLintStep.java#L42 |
It will also break as soon as ktlint goes 1.0 since it only checks the minor version. So if you're going in and fixing it, perhaps only match on |
I'm taking a peek. |
Thanks for diagnosis, fixed in #669, shipped in |
Looks like the API changed again, filing for posterity. 0.38.0-alpha01 is the first release with Kotlin 1.4.0 support
Spotless (gradle) version: 5.1.1
Repro PR (requires changing the version in dependencies.gradle) - uber/crumb#58
Configuration
The text was updated successfully, but these errors were encountered: