ImportOrderStep reads its config file eagerly, rather than lazily

[nedtwigg]

spotless/lib/src/main/java/com/diffplug/spotless/java/ImportOrderStep.java

Lines 56 to 59 in 995b6a9

	public static FormatterStep createFromFile(File importsFile) {
	Objects.requireNonNull(importsFile);
	return createFromOrderImpl(getImportOrder(importsFile));
	}

It shouldn't read the file until its state is calculated. First discovered in #217.

[jbduncan]

I suspect the easiest fix would be to make getImportOrder return a lazy Supplier<List<String>>.

[jbduncan]

...and then memoize the result of this supplier somehow.

[nedtwigg]

FormatterStep.createLazy handles the memoization for you.

[jbduncan]

Cheers for tackling this, @nedtwigg. :)

[nedtwigg]

Published in 3.18.0