Skip to content

Commit

Permalink
As agreed in previous review: Femoval of unnecessary '\f'
Browse files Browse the repository at this point in the history
  • Loading branch information
@fvgh
fvgh committed Apr 8, 2017
1 parent 4becbed commit cdf45fc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion spotlessSelf.gradle
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ spotless {
exclude '_ext/**'
}
custom 'noInternalDeps', noInternalDepsClosure
custom 'preventFormatPingPong', { return it.replaceAll('}[ \t\f]+}', '}}') }
custom 'preventFormatPingPong', { return it.replaceAll('}[ \t]+}', '}}') }
bumpThisNumberIfACustomStepChanges(1)
greclipseFormat().configFile('spotless.eclipseformat.xml', 'spotless.groovyformat.prefs')
}
Expand Down

5 comments on commit cdf45fc

@jbduncan
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fvgh Oh, I've just realised that it would be best to replace the [ \t] part of the regex with \s, since that will catch all whitespace according to https://regexone.com/lesson/whitespaces.

@fvgh
Copy link
Member Author

@fvgh fvgh commented on cdf45fc Apr 8, 2017 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbduncan
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes, you're right! I stand corrected, and happily so. 😄

@fvgh
Copy link
Member Author

@fvgh fvgh commented on cdf45fc Apr 8, 2017 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbduncan
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, you found a lot of things I missed.
Thanks again for all your help.

You are very welcome @fvgh. 😃

I really hope that I get more used to the languages and spotless itself,
so that the next PRs are smoother.

No worries! It's a learning experience for us all. Even I'm not completely familiar with Spotless.

Please, feel free to take your time with learning the parts of Java and Spotless that personally interest you at your own pace. @nedtwigg and I will aim to give you feedback when it matters. :)

Please sign in to comment.