Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a without-deprecated feature #1638

Closed
sgrif opened this issue Apr 12, 2018 · 0 comments
Closed

Introduce a without-deprecated feature #1638

sgrif opened this issue Apr 12, 2018 · 0 comments
Milestone

Comments

@sgrif
Copy link
Member

sgrif commented Apr 12, 2018

We have a lot of deprecations which do not give a warning due to various bugs in Rust. We've been recommending that people try compiling their apps with default features turned off if they're concerned about relying on deprecated code. However, this isn't always enough. If any dependency in the entire graph depends on Diesel without default-features = false, you cannot get rid of deprecated code.

We should introduce an explicit without-deprecated feature meant specifically for "just make sure I'm not depending on deprecated code" testing. Any place where we have feature = "with-deprecated" will need to change to all(feature = "with-deprecated", not(feature = "without-deprecated")).

In an ideal world we shouldn't need this, and nobody should have to wonder if they're relying on deprecated code. However, the number of deprecations we have that do not warn are at a volume where I think this is warranted.

For reference, a few of the bugs in question:

rust-lang/rust#49912
rust-lang/rust#47237
rust-lang/rust#47236
rust-lang/rust#47238

@weiznich weiznich added this to the 2.0 milestone Jun 21, 2020
weiznich added a commit to weiznich/diesel that referenced this issue Oct 7, 2020
Add a `without-deprecated` feature flag that really disables all
deprecated items
weiznich added a commit that referenced this issue Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants