You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have a lot of deprecations which do not give a warning due to various bugs in Rust. We've been recommending that people try compiling their apps with default features turned off if they're concerned about relying on deprecated code. However, this isn't always enough. If any dependency in the entire graph depends on Diesel without default-features = false, you cannot get rid of deprecated code.
We should introduce an explicit without-deprecated feature meant specifically for "just make sure I'm not depending on deprecated code" testing. Any place where we have feature = "with-deprecated" will need to change to all(feature = "with-deprecated", not(feature = "without-deprecated")).
In an ideal world we shouldn't need this, and nobody should have to wonder if they're relying on deprecated code. However, the number of deprecations we have that do not warn are at a volume where I think this is warranted.
We have a lot of deprecations which do not give a warning due to various bugs in Rust. We've been recommending that people try compiling their apps with default features turned off if they're concerned about relying on deprecated code. However, this isn't always enough. If any dependency in the entire graph depends on Diesel without
default-features = false
, you cannot get rid of deprecated code.We should introduce an explicit
without-deprecated
feature meant specifically for "just make sure I'm not depending on deprecated code" testing. Any place where we havefeature = "with-deprecated"
will need to change toall(feature = "with-deprecated", not(feature = "without-deprecated"))
.In an ideal world we shouldn't need this, and nobody should have to wonder if they're relying on deprecated code. However, the number of deprecations we have that do not warn are at a volume where I think this is warranted.
For reference, a few of the bugs in question:
rust-lang/rust#49912
rust-lang/rust#47237
rust-lang/rust#47236
rust-lang/rust#47238
The text was updated successfully, but these errors were encountered: