Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SQLite] Diesel should not have a hard dependency on libpq and libsqlite #159

Closed
sgrif opened this issue Jan 31, 2016 · 1 comment
Closed

[SQLite] Diesel should not have a hard dependency on libpq and libsqlite #159

sgrif opened this issue Jan 31, 2016 · 1 comment
Milestone
0.5

Comments

@sgrif
Copy link
Member

sgrif commented Jan 31, 2016

Note: PRs addressing this issue should target the diesel-sqlite-support branch, not master.

Right now we currently always compile against both. We should only compile against whatever the user wants to use. They should both be able to co-exist in the same app if desired. This can either be done via features, or by moving SQLite and PG into separate crates. I have no preference as to which solution we do, but we should isolate the backend specific things to a single top level module in either case so we don't end up littering #[cfg(feature="whatever")] into our code.
@sgrif sgrif added this to the 0.5 milestone Jan 31, 2016
sgrif added a commit that referenced this issue Feb 2, 2016
@sgrif
Remove hard dependencies on libpq and libsqlite3
c675b47 
All code which *directly* depends on these has been moved to a separate
module and placed behind a cfg attr. There is still a ton of PG specific
stuff hidden in the expressions module that simply isn't marked as such.

I had to rework how we do our boilerplate type impls, as `sqlite` and
`postgres` need to be able to co-exist in the same compile pass (even
just for generating docs).

While this PR is pretty large, it ultimately mostly comes down to
clerical work.

Fixes #159.
@sgrif sgrif mentioned this issue Feb 2, 2016
Merged
sgrif added a commit that referenced this issue Feb 3, 2016
@sgrif
Remove hard dependencies on libpq and libsqlite3
f629171 
All code which *directly* depends on these has been moved to a separate
module and placed behind a cfg attr. There is still a ton of PG specific
stuff hidden in the expressions module that simply isn't marked as such.

I had to rework how we do our boilerplate type impls, as `sqlite` and
`postgres` need to be able to co-exist in the same compile pass (even
just for generating docs).

While this PR is pretty large, it ultimately mostly comes down to
clerical work.

Fixes #159.
sgrif added a commit that referenced this issue Feb 3, 2016
@sgrif
Remove hard dependencies on libpq and libsqlite3
d9f733f 
All code which *directly* depends on these has been moved to a separate
module and placed behind a cfg attr. There is still a ton of PG specific
stuff hidden in the expressions module that simply isn't marked as such.

I had to rework how we do our boilerplate type impls, as `sqlite` and
`postgres` need to be able to co-exist in the same compile pass (even
just for generating docs).

While this PR is pretty large, it ultimately mostly comes down to
clerical work.

Fixes #159.
@sgrif
Copy link
Member Author

sgrif commented Feb 3, 2016

Fixed by #175.

@sgrif sgrif closed this as completed Feb 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5
Development

No branches or pull requests
1 participant
@sgrif