Support Videos inside pages #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
requested changes
Dec 9, 2020
| @@ -285,12 +285,13 @@ String servePageIdForLanguageForPackage(final String packageName, final String p | |||
| case TYPE_HTML: | |||
| html.append(htmlDoc.body().getElementsByTag("div").first().html()); | |||
| html.append(generateFooter(lang, packageName, pageId, faq)); | |||
| res = DocetUtils.cleanPageText(html.toString()); | |||
| res = DocetUtils.cleanPageText(html.toString(), docetConf.isEnableIframe()); | |||
| System.out.println(" docetConf.isEnableIframe() === " + docetConf.isEnableIframe() + "\ncleaned page > " + res); | |||
eolivelli
approved these changes
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In Docet before serving the current page, the HTML gets cleaned up with JSOUP.
Fix
Add a propery
docet.enable.iframe(default false) to skip the iframe clean.In the PDF render the iframes gets cleaned anyway.
Master issue: #71