Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to handle pydicom 3.X #381

Closed
wants to merge 6 commits into from
Closed

Update to handle pydicom 3.X #381

wants to merge 6 commits into from

Conversation

darcymason
Copy link
Contributor

@darcymason darcymason commented Jan 2, 2025 •
edited
Loading

Closes #380

@darcymason
Update pydicom supported to >=2.4..0
a343210 
* fix DVH repr problems with 'np.int(...) repr'
* collections.Callable -> collections.abc.Callable
@darcymason
Resolve fixing of file_meta info
690eebc
@darcymason
Update workflows for testing pydicom 2.4, 3.X
8cb2e37 
* update some of the actions script versions
@pep8speaks
Copy link

pep8speaks commented Jan 2, 2025 •
edited
Loading

Hello @darcymason! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2025-01-02 20:30:35 UTC

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 2, 2025
View reviewed changes
tests/test_dose.py Fixed Show fixed Hide fixed
tests/test_dose.py Fixed Show fixed Hide fixed
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 2, 2025
View reviewed changes
dicompylercore/dicomparser.py Fixed Show fixed Hide fixed
dicompylercore/dicomparser.py Fixed Show fixed Hide fixed
dicompylercore/dicomparser.py Fixed Show fixed Hide fixed
tests/test_dose.py Fixed Show fixed Hide fixed
tests/test_dose.py Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 2, 2025
View reviewed changes
dicompylercore/dicomparser.py Fixed Show fixed Hide fixed
tests/test_dicomparser.py Fixed Show fixed Hide fixed
tests/test_dicomparser.py Fixed Show fixed Hide fixed
tests/test_dose.py Fixed Show fixed Hide fixed
tests/test_dose.py Fixed Show fixed Hide fixed
tests/test_dose.py Fixed Show fixed Hide fixed
tests/test_dose.py Fixed Show fixed Hide fixed
tests/test_dose.py Fixed Show fixed Hide fixed
tests/test_dvhcalc.py Fixed Show fixed Hide fixed
tests/test_dvhcalc.py Fixed Show fixed Hide fixed
@darcymason
Copy link
Contributor Author

Will finish the last bits in a day or so...

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 2, 2025
View reviewed changes
dicompylercore/dvh.py Fixed Show fixed Hide fixed
@darcymason
Fix syntax
e7f9bb8
@darcymason
Update Python versions in setup.py
9ed6ac8 
* make pydicom versions in build name more obvious
@darcymason darcymason mentioned this pull request Jan 2, 2025
Open
@darcymason
Copy link
Contributor Author

Closing this to use #382 instead - redid from PR in my fork, should be cleaner I think.

@darcymason darcymason closed this Jan 2, 2025
@darcymason darcymason mentioned this pull request Jan 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update imports for pydicom >= 3.0
2 participants
@darcymason @pep8speaks