Dose interpolation fix due to indexing issue #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 12, 2020
|
Unfortunately, centering doesn't resolve the issue. Orange is Eclipse and Green is this new method: centering the LUT.
|
|
I should point out that the volume of the structures posted in this PR are ~0.03cc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a shift in the interpolated DVH calculations, even if the resolution was equal to the original dose grid. Upon inspection of the code, it appears as if there were a couple of list indexing issues.
The light blue line is calculated with the current
dicompyler-coremaster. The orange is calculated with Eclipse, and imported as a DICOM DVH. The dark blue line is calculated with this pull request.The edits to lines 165 and 166 were applied intuitively, but I have not done any testing other than to show it doesn't crash.
The
+1's tosampling_rateandextent_dosealone fix the shifted DVH.