-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All operations around PlanoConta are implemented (full CRUD) #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… insert new PlanoConta and editing existing one
…ith an existing `PlanoConta`
…ng `PlanoContaModel` is completed
…trieve it after saving in database
… extension method ConvertToPlanoConta
…rned a RedirectToAction to go back to the list with all `PlanoConta` items
…dden exclusions - Forbidden exclusions are those of PlanoConta items that serve as a foreign key for transactions. - In current implementation there is no error message for the user when exclusion is not possible nor success message when exclusion is performed
- In the context of ASP.NET Core MVC web applications, both model binding and model validation are processes that take place prior to the execution of a controller action. It is imperative for the application to examine the ModelState.IsValid and respond accordingly. This rule enforces the developer to validate the model within a controller action, ensuring the application’s robustness and reliability. - https://rules.sonarsource.com/csharp/tag/asp.net/RSPEC-6967/
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
759ecf0 Simple Javascript functions to simulate actions in Editar and Excluir buttons
48096e7 Fixed
Voltar
function to account for two routes using the same UI - insert new PlanoConta and editing existing one4b4c542 Implemented function under button
Editar
to go toCadastro
page with an existingPlanoConta
8ca2658 Mocked endpoint that returns one
PlanoConta
item for edition3566cb7 Started implementation of editing functionality - Retrieval of existing
PlanoContaModel
is completeda0596c6 Modified PlanoContaService to get id of newly saved PlanoConta and retrieve it after saving in database
5bf9dcd Implemented actions for updating a PlanoConta item
bad9e62 Retrieved the request item id and saved to item to be returned by the extension method ConvertToPlanoConta
bd41167 Added a discard operator in the action that saves a new item and returned a RedirectToAction to go back to the list with all
PlanoConta
itemsa061963 Implemented exclusion of PlanoConta with consideration for some forbidden exclusions
bb2a0f0 Routes in PlanoContaController for full functions to work fine