Refactoring on owl reasoners and some fixes/improvements #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # docs/usage/reasoner.md # tests/test_owlapy_render.py
Demirrr
approved these changes
Oct 31, 2024
|
Thank you. Looking Great. So happy with this PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring/fixes related with issue #79 and #91
AbstractOWLReasonerExis merged intoAbstractOWLReasoner.OntologyReasoneris removed. Logic transfered toFastInstancChekerReasoner.FastInstancChekerReasonerrenamed toStructuralReasoner.Updated documentation in accordance.
Documentation is no longer published when pushing to develop branch.
Added
is_modifiedattribute forOntologyclass which indicates if an ontology is modified, i.e. axioms are added or removed after this ontology was initialized.StructuralReasonerwill disable caching and reset if ontology modification is detected in order to avoid inconsistencies.Changed operator to logical AND for rendering and parsing facet restrictions.
Updated tests in accordance with the changes.