subconcepts is now recursive

[LckyLke]

subconcepts is now recursive to retrieve subconcepts from the whole class hierarchy

[LckyLke]

test_example_concept_learning_neural_evaluation.py seems to have problems with the way we compute the subconcepts.
retrieval_eval.py works perfectly.
I noticed that test_example_concept_learning_neural_evaluation.py give an individual as a class:
Subconcept: OWLClass(IRI('http://www.benchmark.org/family#', 'F10M173'))

[Demirrr]

This can happen because a neural network assigns scores to all possible entities e.i. every subject or object found in a triple

[LckyLke]

should we check than if the current subconcept is in the classes in signature?

[LckyLke]

should we check than if the current subconcept is in the classes in signature?

that seems to fix the issue

i.e.

    def subconcepts(self, named_concept: OWLClass) -> List[OWLClass]:
        all_subconcepts = []
        for subconcept in self.direct_subconcepts(named_concept):
            if subconcept not in self.classes_in_signature():
                return []
            all_subconcepts.append(subconcept)
            all_subconcepts.extend(self.subconcepts(subconcept))
        return all_subconcepts

[Demirrr]

Yes we can do it. Yet, this checking would increase the runtimes. Therefore, please add comments in the code indicating the importance of such checking

[LckyLke]

Yes we can do it. Yet, this checking would increase the runtimes. Therefore, please add comments in the code indicating the importance of such checking

now it would be better to have the classes in signature as a set for avg. O(1) runtime for this check 🤔

[Demirrr]

Absolutely. This should be a to-do for the next next release:)

[LckyLke]

somehow this failed again but locally it did not :/

[Demirrr]

Please disable all_subconcepts for the time being. If the disabling doesn't solve it, I will take a look at it.

[LckyLke]

Please disable all_subconcepts for the time being. If the disabling doesn't solve it, I will take a look at it.

I re-ran the checks and weirdly now everything passed

locally i ran pytest like 20 times and never had a fail