Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add special upvalue for _ENV #35

Closed
dibyendumajumdar opened this issue Sep 30, 2020 · 0 comments
Closed

Add special upvalue for _ENV #35

dibyendumajumdar opened this issue Sep 30, 2020 · 0 comments
Labels
fixed Fix implemented parser Component: Parser

Comments

@dibyendumajumdar
Copy link
Owner

Our upvalue implementation so far assumes that an upvalue references a local symbol in an enclosing function. However _ENV does not fall into this category as there is no local variable of that name in the main chunk. So we need to extend the concept of upvalue to support this special case.
@dibyendumajumdar dibyendumajumdar added the parser Component: Parser label Sep 30, 2020
dibyendumajumdar added a commit that referenced this issue Sep 30, 2020
@dibyendumajumdar
issue #35 make variable name a parameter in new_symbol_reference() as…
4435a85 
… _ENV is not a name directly encountered necessarily
dibyendumajumdar added a commit that referenced this issue Sep 30, 2020
@dibyendumajumdar
issue #35 add _ENV as a stored string in the compiler state
7df1ebf
dibyendumajumdar added a commit that referenced this issue Sep 30, 2020
@dibyendumajumdar
issue #35 first attempt to create upvalue for _ENV
8a39f1b
dibyendumajumdar added a commit that referenced this issue Sep 30, 2020
@dibyendumajumdar
issue #35 apply type to the env symbol
60ec292
dibyendumajumdar added a commit that referenced this issue Sep 30, 2020
@dibyendumajumdar
issue #35 update assertion check to ensure we accept an upvalue that …
6f1b448 
…refers to _ENV
dibyendumajumdar added a commit that referenced this issue Oct 2, 2020
@dibyendumajumdar
issue #35 fixes and updated test results
7b2af91
dibyendumajumdar added a commit that referenced this issue Oct 3, 2020
@dibyendumajumdar
issue #35 more fixes
0f4f01a
dibyendumajumdar added a commit that referenced this issue Oct 3, 2020
@dibyendumajumdar
issue #35 update expected results
123703e
dibyendumajumdar added a commit that referenced this issue Oct 3, 2020
@dibyendumajumdar
issue #35 enhance the lua_variable_symbol structure to hold a referen…
66d35a1 
…ce to the _ENV symbol
dibyendumajumdar added a commit that referenced this issue Oct 3, 2020
@dibyendumajumdar
issue #35 enhance the loadglobal/storeglobal opscodes to also include…
a1f6c49 
… the _ENV symbol. Also fix the storeglobal opcode
dibyendumajumdar added a commit that referenced this issue Oct 3, 2020
@dibyendumajumdar
issue #35 update expected results
59d6c0a
dibyendumajumdar added a commit that referenced this issue Oct 24, 2020
@dibyendumajumdar
issue #35 always create _ENV upvalue in the Lua chunk
8edb43b
dibyendumajumdar added a commit that referenced this issue Oct 24, 2020
@dibyendumajumdar
issue #35 update test results
51b1581
@dibyendumajumdar dibyendumajumdar added the fixed Fix implemented label Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed Fix implemented parser Component: Parser
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dibyendumajumdar