Embedded RGB fixes #70
Conversation
…nd some todo in wasm calls to lambdas (nyi)
| _ => Err(format_err!("Error: Unknown error in import_asset")), | ||
| }, | ||
| } | ||
| pub fn import_asset(genesis: &str) -> Result<ThinAsset> { |
There was a problem hiding this comment.
Ok, the intention of this method is that if we have the descriptor , it returns how much tokens you have.
But really what we need for lambda is that: that if you pass the genesis or contract id AND utxo/blinded you get the ThinAsset with how many tokens you have. And if there are not utxo/blinded, then we simple get what it's being done now.
So instead of rgb_tokens_descripr, must be, utxo: Option<&str>, blinded: Option<&str> and the rest the same
I think the better is that I do a PR with my propose, but bettr give me your opinion on that.
There was a problem hiding this comment.
This method can only get the asset by full genesis, but the genesis should be stored via lambda keyed by rgb id, and retrieved so it can be passed to this method by the client. They should be two separate operations, so that the contents can be encrypted end-to-end. Eventually all RGB methods will be run in WASM or clientside, the RGB lambdas are temporary, but the storage lambdas are permanent.
We should have a separate method that processes an entire consignment and returns all assets and balances. I haven't worked on that yet, but will do after I get transfers working.
Does that all make sense / sound good?
There was a problem hiding this comment.
It makes sense, of course.
There was a problem hiding this comment.
Sounds good, I'll merge now
Includes API changes from earlier this week, plus solves some issues in asset transfer, and includes latest changes from both of Zoe's PRs in rgb-node:
To be clear, the code duplication arrangement is temporary until we can build & contribute Embedded Storm upstream (zmq inproc / in-memory btreemap instead of sled).
The code here only fails because BDK fails to sign the PSBT because it fails to satisfy some condition. It's possible we'll need to use the RGB descriptor wallet to sign and broadcast the PSBT.