Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add utils subcommand #236

Closed
wants to merge 1 commit into from
Closed

[WIP] Add utils subcommand #236

wants to merge 1 commit into from

Conversation

luizirber
Copy link
Member

@luizirber luizirber commented May 17, 2017

Exploring a possible fix to #201

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@luizirber luizirber changed the title Add utils subcommand [WIP] Add utils subcommand May 17, 2017
@codecov-io
Copy link

codecov-io commented May 17, 2017

Codecov Report

Merging #236 into master will decrease coverage by 4.7%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #236      +/-   ##
==========================================
- Coverage   90.75%   86.05%   -4.71%     
==========================================
  Files          33       13      -20     
  Lines        5010     1958    -3052     
  Branches       36       52      +16     
==========================================
- Hits         4547     1685    -2862     
+ Misses        463      263     -200     
- Partials        0       10      +10
Impacted Files Coverage Δ
sourmash_lib/__main__.py 91.66% <75%> (ø)
sourmash_lib/__init__.py 100% <0%> (ø) ⬆️
tests/test_lca.py
sourmash/lca/lca_utils.py
sourmash/lca/command_rankinfo.py
benchmarks/benchmarks.py
tests/test_api.py
sourmash/lca/command_summarize.py
sourmash/logging.py
sourmash/commands.py
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 988459c...dae9ea9. Read the comment docs.

@ctb ctb mentioned this pull request May 20, 2017
@luizirber luizirber force-pushed the feature/utils_subcmd branch from 68374f5 to c7a79ef Compare May 21, 2017 19:02
@luizirber luizirber force-pushed the feature/utils_subcmd branch from 6693797 to dae9ea9 Compare August 22, 2018 20:10
@luizirber luizirber closed this Jan 5, 2020
@luizirber luizirber deleted the feature/utils_subcmd branch January 5, 2020 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants