Replace hoehrmann_utf8 with SheenBidi #7698
Draft
+45
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glebm
force-pushed
the
sheenbidi
branch
2 times, most recently
from
ea95100 to
f6bc014
Compare
AJenbo
previously approved these changes
Feb 2, 2025
AJenbo
approved these changes
Feb 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SheenBidi can be used for RTL support, e.g. #7512
It also provides UTF-8 decoding functions, so we might as well use them instead of the library we used previously.
Draft while CMake support is being integrated upstream (Tehreer/SheenBidi#27)
/cc @BLooperZ