Fix spacing for 100M+ XP

[vlolteanu]

Depending on how "fat" the digits happen to be, regular spacing in the char panel might be too wide at 100M XP. Notice how the "1" is really awkwardly placed. Something similar happens at 1B.

Before:

After:

[kphoenix137]

How do we determine spacing in the Info Panel? Maybe it would be more maintainable to use the same method. I mean this for all of the Character panel values as well. The current method feels quite "hardcodey".

[vlolteanu]

How do we determine spacing in the Info Panel? Maybe it would be more maintainable to use the same method. I mean this for all of the Character panel values as well. The current method feels quite "hardcodey".

I guess we could render the text to some internal buffer using smaller and smaller spacing until it fits.

The alternative is to stress-test stuff by hand using zeroes and see what the breakpoints are.It's just XP and DMG in the char panel; the others fit just fine.

[StephenCWills]

How do we determine spacing in the Info Panel?

We just pass UiFlags::KerningFitSpacing into DrawString(). The rendering function figures out what the spacing should be by computing the width of the string before rendering and comparing it to the size of the bounding box for the text.

[kphoenix137]

Do we still need this PR with the new one being open?

[StephenCWills]

There is a new issue, but no new PR.

[kphoenix137]

There is a new issue, but no new PR.

Sorry, I mistook that for a PR 😂

[AJenbo]

How do we determine spacing in the Info Panel?

We just pass UiFlags::KerningFitSpacing into DrawString(). The rendering function figures out what the spacing should be by computing the width of the string before rendering and comparing it to the size of the bounding box for the text.

@vlolteanu feel free to open a new PR that implements this suggestion

[glebm]

I think @kphoenix137 has a fix ready, just needs to finish his PR that fixes kerning fit when centered