Replaces uses of doubles with floats #7455
Merged
+28
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glebm
force-pushed
the
double-to-float-2
branch
2 times, most recently
from
a8faa7c
to
c8e729c
Compare
AJenbo
previously approved these changes
Oct 4, 2024
AJenbo
reviewed
Oct 4, 2024
Looks like the KallistiOS Dreamcast SDK disables double support by default: https://github.com/KallistiOS/KallistiOS/blob/495e77fd60d5b09a1ad52a26cd4a7e73cd0d9d51/environ_dreamcast.sh#L16 We don't really need doubles in this code. The one place where we might have needed them is the SMK video decoder, handled in a separate PR.
glebm
force-pushed
the
double-to-float-2
branch
from
c8e729c
to
a25020d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the KallistiOS Dreamcast SDK disables double support by default: https://github.com/KallistiOS/KallistiOS/blob/495e77fd60d5b09a1ad52a26cd4a7e73cd0d9d51/environ_dreamcast.sh#L16
We don't really need doubles in this code.
The one place where we might have needed them is the SMK video decoder, handled in a separate PR (#7454).
/cc @azihassan I'm not entirely sure but perhaps this will help with azihassan#8