Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed-up debug grid #7436

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Speed-up debug grid #7436

merged 1 commit into from
Sep 26, 2024

Conversation

glebm
Copy link
Collaborator

@glebm glebm commented Sep 26, 2024

dev.display.grid() previously tanked the FPS even on my beefy machine. It is now much faster.

I've also noticed that the grid is glitchy when moving up/down but this is also the case before this PR.

Before After
grid-before grid-after

@glebm glebm enabled auto-merge (rebase) September 26, 2024 20:49
@glebm glebm marked this pull request as draft September 26, 2024 20:57
auto-merge was automatically disabled September 26, 2024 20:57

Pull request was converted to draft

`dev.display.grid()` previously tanked the FPS even on my beefy machine.
It is now much faster.

I've also noticed that the grid is glitchy when but this is also the
case before this PR.
@glebm glebm marked this pull request as ready for review September 26, 2024 21:14
@glebm glebm enabled auto-merge (rebase) September 26, 2024 21:14
@qndel
Copy link
Member

qndel commented Sep 26, 2024

Before and after screenshots look the same to me, what am I looking for? :)

@AJenbo
Copy link
Member

AJenbo commented Sep 26, 2024

Before and after screenshots look the same to me, what am I looking for? :)

The FPS jumped from 27 to 58

@AJenbo AJenbo merged commit 67f822f into diasurgical:master Sep 26, 2024
22 of 23 checks passed
@glebm glebm deleted the fast-grid branch September 27, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants