Cleanup Store code #7424
Draft
Cleanup Store code #7424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I'll submit a PR separately that changes the variable names found in stores.cpp so this PR is much easier to review. |
|
I think you should, this one already has conflicts despite being the latest |
kphoenix137
force-pushed
the
stores-cleanup
branch
from
34b6132
to
705e5f6
Compare
|
Do your self a favor and merge master rather then rebase on it with the commits you have. |
kphoenix137
force-pushed
the
stores-cleanup
branch
2 times, most recently
from
508bfa3
to
4f8819a
Compare
Update Refactor Smith menu Clean up the smith main menu with helper functions, and prevent utilizing the line number to figure out what functions to call. Clean up Main Menu more Separate strings Refactor and general fns Note: There is a bug where wirt's item can only be clicked on the item name Consolidate Sell functions Consolidate canselltotowner Fix bad rebase Fix accidental change Add IsPlayerInStore() Rename/organize Update stores.cpp Update stores.h Rename playerItemIdx Renames and fix IsPlayerInStore() RestoreResource()
kphoenix137
force-pushed
the
stores-cleanup
branch
from
95cd85b
to
3e5daee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.