Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CPack NSIS Windows Installer #7134

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Conversation

Trihedraf
Copy link
Collaborator

This adds a CPack Generator for a Windows Installer. To add to cmake command is -DWIN_NSIS=ON.

Install

Screenshot 2024-06-06 231353

Screenshot 2024-06-06 231427

Screenshot 2024-06-06 231444

Screenshot 2024-06-06 231459

Screenshot 2024-06-06 231515

Uninstall

Screenshot 2024-06-06 231543

Screenshot 2024-06-06 231555

@AJenbo
Copy link
Member

AJenbo commented Jul 1, 2024

Good old NSIS, I used to dable in it back in the day and make custom installers for various games and applications which had awfuller installation processes.

I have noticed that a large lumber of .msi installers are actually just a wrapped NSIS installer, do you think it would be simple enough to make a script to do this?

@Trihedraf
Copy link
Collaborator Author

First installer I've ever made, let alone trying extra stuff. This was just in CMake already, so I was able to make it spit it out with reasonably small changes and decent result. I could look into it at some point though.

@AJenbo AJenbo merged commit 04bd887 into diasurgical:master Jul 1, 2024
22 checks passed
@AJenbo
Copy link
Member

AJenbo commented Jul 1, 2024

That would be really helpful. I'm all for providing an installer, but unfortunately a lot of AV will prevent users from downloading .exe files but will allow .msi so that is what prevents us from using NSIS for it. Additionally it's only possible to generate MSI installers on Windows (using the WIX generator in CPack).

Update: After some digging it turns out that WIX is only even build for CPack on Windows platforms, so we would need to invoke it externally even if we manage to install WiX via Wine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants