-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Flamedart #7076
Fix Flamedart #7076
Conversation
I remember we had a discussion with Stephen about this. The melee fire affix makes breaking barrels show with the fire effect. An alternative fix would be to make all elemental bows show that effect when breaking barrels. Either way, this is just a visual change. Keeping this bow unique, making it like the others or making all elemental bows show the effect. |
It's not just a visual change. The melee attack on the barrel spawns the |
I agree that it's a mistake. And it results in a super confusing item description with two fire ranges and no mention of barrels. The only alternative is that it's a cheap hack for unique fire bows. But you would encounter 30 regular fire bows before you ever found this unique, so how would you playtest and not notice this as a general problem needing a general fix? Either all fire bows should do fire damage to wooden barrels or none of them. |
Yeah, I think they all should. |
And lightning bows as well is implied? I think this fix should come first and then bows doing melee should be addressed in another PR |
I agree with FitzRoyx and Stephen. I think it makes sense for all bows to have this effect and remove the duplicate description. |
ae665b6
to
ddcc4db
Compare
I don't quite understand, it was melee fire damage 1-6, how is the logical fix fire resistance 20%? |
What? |
I've made a fix PR for this unique before, however that PR did 2 different things. Let's start smaller and just fix what's blatantly wrong with this unique first, which is that it has a melee item power when it's a ranged weapon.