Xbox One/Series support #3946
Xbox One/Series support #3946
Conversation
They are used for the OS and store not for the game itself so i guess we can remove a good amount of them. |
|
i removed all images but the recommended scale which is |
|
It's not perfect but it's a good start, and we can improve the CMake stuff after the merge. LGTM on the CMake stuff. Please run |
|
Do you think its possible to run the build on appveyor? |
i do think so https://www.appveyor.com/docs/windows-images-software/#visual-studio-2022 |
|
If you can figure that out it would be much appreciated :) You can see our existing script here: https://github.com/diasurgical/devilutionX/blob/master/appveyor.yml |
i do think this is it 681ce04 |
| 3. In the first popup - called `Deploy or Install Application` choose `devilutionX..appx` and then click `Next` | ||
| 4. In the second popup - called `Choose any necessary dependencies` choose `Microsoft.VCLibs..appx` and then click `Start` |
There was a problem hiding this comment.
Sorry, slipped up with my suggestion here :)
| 3. In the first popup - called `Deploy or Install Application` choose `devilutionX..appx` and then click `Next` | |
| 4. In the second popup - called `Choose any necessary dependencies` choose `Microsoft.VCLibs..appx` and then click `Start` | |
| 3. In the first popup - called `Deploy or Install Application` choose `devilutionX.appx` and then click `Next` | |
| 4. In the second popup - called `Choose any necessary dependencies` choose `Microsoft.VCLibs.appx` and then click `Start` |
Hm looks like I have to setup a second project for the same repo, or the script has to be woven in to the other one using a build matrix configuration. I have setup a secound project on appveyor for now, lets see if it triggers on the next update. |
| <None Include="..\build\assets\*\*.*"> | ||
| <DeploymentContent>true</DeploymentContent> | ||
| <Link>Assets\%(RecursiveDir)%(Filename)%(Extension)</Link> | ||
| </None> |
There was a problem hiding this comment.
this does the trick of adding the assets
There was a problem hiding this comment.
TBH i don't think that there is a need for generating this file with cmake as it is pretty generic already.
|
@glebm I think this is ready for merging, do you still have unresolved parts or can the conversations be closed? |
|
@fwannmacher thanks for the work with getting this up to speed 👍 I noticed that the appveyor job didn't trigger, could you try and implement it as a build matrix of the regular job as a follow up PR? |
TBH i'm not used with appveyor so if you know someone more used to it i think that would be better. |
|
Unfortunately not, this is the only time I have used it since I don't have windows I don't often get involved with development on the platform. |
Ok... I'll try to find it out |
Added support for Xbox One/Series.